Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serialize_all in AsRefStr, AsStaticStr and IntoStaticStr #42

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Fix serialize_all in AsRefStr, AsStaticStr and IntoStaticStr #42

merged 1 commit into from
Feb 19, 2019

Conversation

xosdy
Copy link
Contributor

@xosdy xosdy commented Jan 6, 2019

No description provided.

@Peternator7
Copy link
Owner

@xosdy , Thanks for opening a PR! Sorry for the delay in looking at it, I've been busy after the holidays. Could you confirm for me what this is fixing? Was serialize all not being invoked in specific instances?

@xosdy
Copy link
Contributor Author

xosdy commented Feb 19, 2019

Yes, AsRefStr, AsStaticStr, IntoStaticStr are not serialized by the serialize_all rule.

@Peternator7 Peternator7 merged commit 7605c67 into Peternator7:master Feb 19, 2019
@Peternator7 Peternator7 mentioned this pull request Mar 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xosdy @Peternator7